[PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

Yuan, Perry Perry.Yuan at dell.com
Tue Mar 23 07:22:21 CET 2021


Hi Pierre:

> -----Original Message-----
> From: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> Sent: Monday, March 22, 2021 10:50 PM
> To: Perry Yuan; Yuan, Perry; pobrn at protonmail.com;
> oder_chiou at realtek.com; perex at perex.cz; tiwai at suse.com;
> hdegoede at redhat.com; mgross at linux.intel.com; Limonciello, Mario
> Cc: linux-kernel at vger.kernel.org; alsa-devel at alsa-project.org;
> broonie at kernel.org; lgirdwood at gmail.com; platform-driver-
> x86 at vger.kernel.org
> Subject: Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell
> hardware privacy
> 
> 
> [EXTERNAL EMAIL]
> 
> 
> > As you suggested,I should add the alignment change in another patch.
> > But if i keep the old alignment, the code will be very odd.
> > Seems like that I have to change the below code to new alignment in
> > this patch.
> >
> > if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&
> >      dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { <<--- changed
> > back
> >      if (!privacy_valid)
> >              has_privacy = true;
> >      else
> >              has_privacy = false;
> >      if (!has_privacy) {
> >          micmute_led_cdev.brightness <<----------- new alignment
> >          ...
> >      }
> > ...
> > }
> 
> I don't get the point, sorry. The code above doesn't seem properly indented
> or there were spurious tab/spaces conversions?
Could you help to take a look the V5 patch ?
I recovery some part of original code alignment and add my new codes with new Tabs added 
Thank you !

Perry



More information about the Alsa-devel mailing list