[PATCH 1/2] ASoC: rt715: add main capture switch and main capture volume

Jaroslav Kysela perex at perex.cz
Fri Mar 19 07:54:21 CET 2021


Dne 19. 03. 21 v 4:03 Jack Yu napsal(a):
> Add main capture switch and main capture volume control.
> Main capture control has its own channel value respectivelly.

It's a 'deja vu' without a proper solution. Please, resolve issues described
in the first thread:

https://lore.kernel.org/alsa-devel/20201214064903.2746-1-jack.yu@realtek.com/#t

It's bad to map multiple controls to operate on top of the same registers
without any kind of synchronization.

Also, I note that the put callback should return 1 when the value is changed.
Your callbacks return only 0 in all cases.

I would not apply this patch.

						Jaroslav

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


More information about the Alsa-devel mailing list