[PATCH v2 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier

David Rhodes drhodes at opensource.cirrus.com
Wed Jun 30 23:35:07 CEST 2021


On 6/29/21 6:51 PM, Pierre-Louis Bossart wrote:
> 
>> +#ifdef CONFIG_ACPI
>> +static const struct acpi_device_id cs35l41_acpi_match[] = {
>> +	{ "CSC3541", 0 }, /* Cirrus Logic PCI ID + part ID */
> 
> Wrong comment or wrong ID, "CSC" is clearly not a PCI ID?
> 

CSC is a PnP ID, not a PCI ID. I will change the comment to reflect this.

Thanks for the review. I will fix the license headers, NULL checks, 
includes, dev_crit, and inits in the next revision as well.


More information about the Alsa-devel mailing list