[PATCH] ALSA: oss: Remove redundant assignment to src_access

Jiapeng Chong jiapeng.chong at linux.alibaba.com
Tue Jun 15 12:53:43 CEST 2021


Variable src_access is set to 'dst_access', but this value is never read
as it is not used later on, hence it is a redundant assignment and can
be removed.

Clean up the following clang-analyzer warning:

sound/core/oss/pcm_plugin.c:472:4: warning: Value stored to 'src_access'
is never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci at linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong at linux.alibaba.com>
---
 sound/core/oss/pcm_plugin.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/core/oss/pcm_plugin.c b/sound/core/oss/pcm_plugin.c
index 061ba06..a7c0e50 100644
--- a/sound/core/oss/pcm_plugin.c
+++ b/sound/core/oss/pcm_plugin.c
@@ -469,7 +469,6 @@ int snd_pcm_plug_format_plugins(struct snd_pcm_substream *plug,
 				return err;
 			}
 			srcformat = tmpformat;
-			src_access = dst_access;
 		}
 		tmpformat.rate = dstformat.rate;
         	err = snd_pcm_plugin_build_rate(plug,
-- 
1.8.3.1



More information about the Alsa-devel mailing list