[PATCH][next][V2] ASoC: rsnd: check for zero node count
Colin King
colin.king at canonical.com
Thu Jun 3 13:03:15 CEST 2021
From: Colin Ian King <colin.king at canonical.com>
Most callers of_get_child_count() check that "nr" is non-zero so it
causes a static checker warning when we don't do that here. This
does not cause a problem or a crash, but having zero SSUIes does not
make sense either so let's add a check.
Addresses-Coverity: ("Unchecked return value")
Fixes: c413983eb66a ("ASoC: rsnd: adjust disabled module")
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
V2: Rephrase commit message based on Dan Carpenter's suggestion.
Thanks Dan!
---
sound/soc/sh/rcar/ssiu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c
index 5682c74bb7ff..0d8f97633dd2 100644
--- a/sound/soc/sh/rcar/ssiu.c
+++ b/sound/soc/sh/rcar/ssiu.c
@@ -515,6 +515,9 @@ int rsnd_ssiu_probe(struct rsnd_priv *priv)
else
nr = priv->ssi_nr;
+ if (!nr)
+ return -EINVAL;
+
ssiu = devm_kcalloc(dev, nr, sizeof(*ssiu), GFP_KERNEL);
if (!ssiu)
return -ENOMEM;
--
2.31.1
More information about the Alsa-devel
mailing list