[PATCH 1/5] ASoC: amd: Fix reference to PCM buffer address

Takashi Iwai tiwai at suse.de
Fri Jul 30 20:14:04 CEST 2021


On Fri, 30 Jul 2021 18:20:25 +0200,
Mark Brown wrote:
> 
> On Wed, Jul 28, 2021 at 01:23:49PM +0200, Takashi Iwai wrote:
> > PCM buffers might be allocated dynamically when the buffer
> > preallocation failed or a larger buffer is requested, and it's not
> > guaranteed that substream->dma_buffer points to the actually used
> > buffer.  The driver needs to refer to substream->runtime->dma_addr
> > instead for the buffer address.
> 
> This breaks the build for me on an x86-64 allmodconfig:
> 
> /mnt/kernel/sound/soc/amd/renoir/acp3x-pdm-dma.c: In function 'acp_pdm_dma_hw_params':
> /mnt/kernel/sound/soc/amd/renoir/acp3x-pdm-dma.c:245:18: error: 'runtime' undeclared (first use in this function); did you mean 'vtime'?
>   rtd->dma_addr = runtime->dma_addr;
>                   ^~~~~~~
>                   vtime

Oops, will resubmit the fixed patch set.


thanks,

Takashi


More information about the Alsa-devel mailing list