[PATCH 3/3] dt-bindings: dsp: fsl: Document newly introduced fsl, properties
Rob Herring
robh+dt at kernel.org
Thu Jul 15 16:59:21 CEST 2021
On Thu, Jul 15, 2021 at 8:18 AM Daniel Baluta <daniel.baluta at oss.nxp.com> wrote:
>
> From: Daniel Baluta <daniel.baluta at nxp.com>
>
> Document firmware-name, tplg-name and machine-drv-name properties.
That's obvious from the diff.
Why do you need these?
>
> Signed-off-by: Daniel Baluta <daniel.baluta at nxp.com>
> ---
> .../devicetree/bindings/dsp/fsl,dsp.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> index 7afc9f2be13a..8095aa178e7c 100644
> --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
> @@ -60,6 +60,22 @@ properties:
> used by DSP (see bindings/reserved-memory/reserved-memory.txt)
> maxItems: 1
>
> + firmware-name:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + If present, name of the file within the firmware search path containing
> + the DSP firmware loaded by SOF at DSP boot time.
> +
> + tplg-name:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + Should contain the audio topology file name loaded by SOF driver.
Is this some format the DSP requires? Why do we need a separate file?
This is defined by the board or user config?
> +
> + machine-drv-name:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + Contains the ASoC machine driver name used by SOF to handle DSP audio scenario.
Umm, no.
> +
> required:
> - compatible
> - reg
> @@ -69,6 +85,8 @@ required:
> - mboxes
> - mbox-names
> - memory-region
> + - tplg-name
> + - machine-drv-name
>
> additionalProperties: false
>
> @@ -90,4 +108,6 @@ examples:
> mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1";
> mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>;
> memory-region = <&dsp_reserved>;
> + tplg-name = "sof-imx8-wm8960.tplg";
> + machine-drv-name = "asoc-simple-card";
> };
> --
> 2.27.0
>
More information about the Alsa-devel
mailing list