[PATCH 3/3] ASoC: wm_adsp: Remove pointless string comparison

Charles Keepax ckeepax at opensource.cirrus.com
Tue Jul 13 14:33:38 CEST 2021


On Mon, Jun 28, 2021 at 05:58:37PM +0100, Mark Brown wrote:
> On Sat, Jun 26, 2021 at 04:59:41PM +0100, Charles Keepax wrote:
> 
> > The control fw_name is always directly assigned from the wm_adsp_fw_text
> > array, so it isn't necessary to compare the actual strings just the
> > pointer values.
> 
> This feels like it's asking for trouble in the future...

Thanks for applying anyway, apologies for my slow reply been off work.
We already have the same optimisation in other places so at least this
way its all broken in the same way if we hit an issue in the
future :-)

Thanks,
Charles


More information about the Alsa-devel mailing list