[PATCH 09/12] ASoC: amd: add vangogh i2s dai driver ops

Mukunda,Vijendar vijendar.mukunda at amd.com
Thu Jul 8 13:30:49 CEST 2021


On 7/7/21 10:05 PM, Mark Brown wrote:
> On Wed, Jul 07, 2021 at 11:26:20AM +0530, Vijendar Mukunda wrote:
> 
>> +	mode = fmt & SND_SOC_DAIFMT_MASTER_MASK;
>> +	switch (mode) {
>> +	case SND_SOC_DAIFMT_CBS_CFS:
>> +		adata->master_mode = I2S_MASTER_MODE_ENABLE;
>> +		break;
>> +	case SND_SOC_DAIFMT_CBM_CFM:
>> +		adata->master_mode = I2S_MASTER_MODE_DISABLE;
>> +		break;
>> +	}
> 
> As part of moving to more modern terminology it'd be good to move to
> _DAIFMT_CLOCK_PROVIDER_MASK and associated constants (with a similar
> change for the driver local constant) - see f026c12300 (ASoC: topology:
> use inclusive language for bclk and fsync).
> 

We will modify the code and will post the new version.


More information about the Alsa-devel mailing list