[PATCH] ASoC: add dai_reoder flag to reverse the stop sequence
Mukunda,Vijendar
vijendar.mukunda at amd.com
Mon Jul 5 21:14:45 CEST 2021
On 7/5/21 11:36 PM, kernel test robot wrote:
> Hi Vijendar,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on asoc/for-next]
> [also build test WARNING on v5.13 next-20210701]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit-scm.com%2Fdocs%2Fgit-format-patch&data=04%7C01%7Cvijendar.mukunda%40amd.com%7Ce5b275b4ac8a495cb82908d93fdfaeed%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637611055054720345%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=osK4Tiu040qnydE9OQc1v7cDJyUe3agQooPSJPsallo%3D&reserved=0]
>
> url: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FVijendar-Mukunda%2FASoC-add-dai_reoder-flag-to-reverse-the-stop-sequence%2F20210705-234319&data=04%7C01%7Cvijendar.mukunda%40amd.com%7Ce5b275b4ac8a495cb82908d93fdfaeed%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637611055054720345%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2FIzzuIaGPiIoWh8Z3EtcOjP8kzMhFId9UuD6jqfgCj4%3D&reserved=0
> base: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fbroonie%2Fsound.git&data=04%7C01%7Cvijendar.mukunda%40amd.com%7Ce5b275b4ac8a495cb82908d93fdfaeed%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637611055054720345%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RqAZaoQ5hrjmmPExq93uE0u%2FwP5B%2FUfIFg89n5JHHLY%3D&reserved=0 for-next
> config: i386-randconfig-r031-20210705 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
> # https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommit%2Fa132ec819f3d15c103f3afb5f3e8154355fafdfc&data=04%7C01%7Cvijendar.mukunda%40amd.com%7Ce5b275b4ac8a495cb82908d93fdfaeed%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637611055054725344%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=JzibVA7BhCqtGUkwPhzuhRiVR4pZaGSRa4DJSPY95bo%3D&reserved=0
> git remote add linux-review https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux&data=04%7C01%7Cvijendar.mukunda%40amd.com%7Ce5b275b4ac8a495cb82908d93fdfaeed%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637611055054725344%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=f0T04nTP2VDF8rHdcbAhkSDU2CQdpeMYVjL8NrIOGWM%3D&reserved=0
> git fetch --no-tags linux-review Vijendar-Mukunda/ASoC-add-dai_reoder-flag-to-reverse-the-stop-sequence/20210705-234319
> git checkout a132ec819f3d15c103f3afb5f3e8154355fafdfc
> # save the attached .config to linux build tree
> make W=1 ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp at intel.com>
>
> All warnings (new ones prefixed by >>):
>
> sound/soc/soc-pcm.c: In function 'soc_pcm_trigger':
> sound/soc/soc-pcm.c:1019:3: error: expected expression before 'struct'
> 1019 | + struct snd_soc_card *card = rtd->card;
Extra + symbol introduced build error. Will repost the new version.
> | ^~~~~~
>>> sound/soc/soc-pcm.c:1020:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
> 1020 | int ret = -EINVAL, _ret = 0;
> | ^~~
> sound/soc/soc-pcm.c:1060:7: error: 'card' undeclared (first use in this function)
> 1060 | if (card->dai_reorder) {
> | ^~~~
> sound/soc/soc-pcm.c:1060:7: note: each undeclared identifier is reported only once for each function it appears in
> sound/soc/soc-pcm.c:1018:30: warning: unused variable 'rtd' [-Wunused-variable]
> 1018 | struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
> | ^~~
>
>
> vim +1020 sound/soc/soc-pcm.c
>
> ddee627cf6bb60 Liam Girdwood 2011-06-09 1015
> 836367be289d5b Kuninori Morimoto 2020-06-04 1016 static int soc_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
> ddee627cf6bb60 Liam Girdwood 2011-06-09 1017 {
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1018 struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1019 + struct snd_soc_card *card = rtd->card;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 @1020 int ret = -EINVAL, _ret = 0;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1021 int rollback = 0;
> ddee627cf6bb60 Liam Girdwood 2011-06-09 1022
> 836367be289d5b Kuninori Morimoto 2020-06-04 1023 switch (cmd) {
> 836367be289d5b Kuninori Morimoto 2020-06-04 1024 case SNDRV_PCM_TRIGGER_START:
> 836367be289d5b Kuninori Morimoto 2020-06-04 1025 case SNDRV_PCM_TRIGGER_RESUME:
> 836367be289d5b Kuninori Morimoto 2020-06-04 1026 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1027 ret = snd_soc_link_trigger(substream, cmd, 0);
> ddee627cf6bb60 Liam Girdwood 2011-06-09 1028 if (ret < 0)
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1029 goto start_err;
> ddee627cf6bb60 Liam Girdwood 2011-06-09 1030
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1031 ret = snd_soc_pcm_component_trigger(substream, cmd, 0);
> b8135864d4d33d Kuninori Morimoto 2017-10-11 1032 if (ret < 0)
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1033 goto start_err;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1034
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1035 ret = snd_soc_pcm_dai_trigger(substream, cmd, 0);
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1036 start_err:
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1037 if (ret < 0)
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1038 rollback = 1;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1039 }
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1040
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1041 if (rollback) {
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1042 _ret = ret;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1043 switch (cmd) {
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1044 case SNDRV_PCM_TRIGGER_START:
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1045 cmd = SNDRV_PCM_TRIGGER_STOP;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1046 break;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1047 case SNDRV_PCM_TRIGGER_RESUME:
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1048 cmd = SNDRV_PCM_TRIGGER_SUSPEND;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1049 break;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1050 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1051 cmd = SNDRV_PCM_TRIGGER_PAUSE_PUSH;
> 836367be289d5b Kuninori Morimoto 2020-06-04 1052 break;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1053 }
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1054 }
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1055
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1056 switch (cmd) {
> 836367be289d5b Kuninori Morimoto 2020-06-04 1057 case SNDRV_PCM_TRIGGER_STOP:
> 836367be289d5b Kuninori Morimoto 2020-06-04 1058 case SNDRV_PCM_TRIGGER_SUSPEND:
> 836367be289d5b Kuninori Morimoto 2020-06-04 1059 case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1060 if (card->dai_reorder) {
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1061 ret = snd_soc_pcm_component_trigger(substream, cmd, rollback);
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1062 if (ret < 0)
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1063 break;
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1064
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1065 ret = snd_soc_pcm_dai_trigger(substream, cmd, rollback);
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1066 if (ret < 0)
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1067 break;
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1068 } else {
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1069 ret = snd_soc_pcm_dai_trigger(substream, cmd, rollback);
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1070 if (ret < 0)
> 836367be289d5b Kuninori Morimoto 2020-06-04 1071 break;
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1072
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1073 ret = snd_soc_pcm_component_trigger(substream, cmd, rollback);
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1074 if (ret < 0)
> 836367be289d5b Kuninori Morimoto 2020-06-04 1075 break;
> a132ec819f3d15 Vijendar Mukunda 2021-07-05 1076 }
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1077 ret = snd_soc_link_trigger(substream, cmd, rollback);
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1078 break;
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1079 }
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1080
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1081 if (_ret)
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1082 ret = _ret;
> 6374f493d93b22 Kuninori Morimoto 2020-12-01 1083
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1084 return ret;
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1085 }
> 4378f1fbe92405 Peter Ujfalusi 2019-09-27 1086
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=04%7C01%7Cvijendar.mukunda%40amd.com%7Ce5b275b4ac8a495cb82908d93fdfaeed%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637611055054725344%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=1BE3N8mS0LUpanKs2CGxygLVYLO3dQxpC2CprbqJeIU%3D&reserved=0
>
More information about the Alsa-devel
mailing list