[PATCH 1/6] soundwire: qcom: add support to missing transport params
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Fri Jan 29 20:20:38 CET 2021
> struct qcom_swrm_port_config {
> u8 si;
> u8 off1;
> u8 off2;
> u8 bp_mode;
> + u8 hstart;
> + u8 hstop;
> + u8 word_length;
> + u8 bgp_count;
I couldn't figure out what 'bgp' was and had to search. Not sure how you
came up with this abbreviation of "qcom,ports-block-group-count". Adding
a comment wouldn't hurt.
> + u8 lane_control;
Are you able to use lane_control != 0 ? I thought we were missing stuff
at the bus.c level?
More information about the Alsa-devel
mailing list