[PATCH v3 4/5] amba: Make the remove callback return void
Takashi Iwai
tiwai at suse.de
Wed Jan 27 07:50:23 CET 2021
On Tue, 26 Jan 2021 17:58:34 +0100,
Uwe Kleine-König wrote:
>
> All amba drivers return 0 in their remove callback. Together with the
> driver core ignoring the return value anyhow, it doesn't make sense to
> return a value here.
>
> Change the remove prototype to return void, which makes it explicit that
> returning an error value doesn't work as expected. This simplifies changing
> the core remove callback to return void, too.
>
> Reviewed-by: Ulf Hansson <ulf.hansson at linaro.org>
> Reviewed-by: Arnd Bergmann <arnd at arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni at bootlin.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> Acked-by: Krzysztof Kozlowski <krzk at kernel.org> # for drivers/memory
> Acked-by: Mark Brown <broonie at kernel.org>
> Acked-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
> drivers/amba/bus.c | 5 ++---
> drivers/char/hw_random/nomadik-rng.c | 3 +--
> drivers/dma/pl330.c | 3 +--
> drivers/gpu/drm/pl111/pl111_drv.c | 4 +---
> drivers/hwtracing/coresight/coresight-catu.c | 3 +--
> drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 +---
> drivers/hwtracing/coresight/coresight-cti-core.c | 4 +---
> drivers/hwtracing/coresight/coresight-etb10.c | 4 +---
> drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +---
> drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +---
> drivers/hwtracing/coresight/coresight-funnel.c | 4 ++--
> drivers/hwtracing/coresight/coresight-replicator.c | 4 ++--
> drivers/hwtracing/coresight/coresight-stm.c | 4 +---
> drivers/hwtracing/coresight/coresight-tmc-core.c | 4 +---
> drivers/hwtracing/coresight/coresight-tpiu.c | 4 +---
> drivers/i2c/busses/i2c-nomadik.c | 4 +---
> drivers/input/serio/ambakmi.c | 3 +--
> drivers/memory/pl172.c | 4 +---
> drivers/memory/pl353-smc.c | 4 +---
> drivers/mmc/host/mmci.c | 4 +---
> drivers/rtc/rtc-pl030.c | 4 +---
> drivers/rtc/rtc-pl031.c | 4 +---
> drivers/spi/spi-pl022.c | 5 ++---
> drivers/tty/serial/amba-pl010.c | 4 +---
> drivers/tty/serial/amba-pl011.c | 3 +--
> drivers/vfio/platform/vfio_amba.c | 3 +--
> drivers/video/fbdev/amba-clcd.c | 4 +---
> drivers/watchdog/sp805_wdt.c | 4 +---
> include/linux/amba/bus.h | 2 +-
> sound/arm/aaci.c | 4 +---
For the sound/*:
Acked-by: Takashi Iwai <tiwai at suse.de>
thanks,
Takashi
More information about the Alsa-devel
mailing list