[PATCH alsa-ucm-conf 1/3] chtnau8824: Move DAC Channel Source selection to Speaker/Headphones EnableSeq

[Hans de Goede]

Hi,

On 1/18/21 3:40 PM, Jaroslav Kysela wrote:
> Dne 17. 01. 21 v 17:52 Jaroslav Kysela napsal(a):
>> Dne 17. 01. 21 v 17:09 Hans de Goede napsal(a):
>>> Hi,
>>>
>>> On 12/16/20 4:38 PM, Hans de Goede wrote:
>>>> Move DAC Channel Source selection to Speaker/Headphones EnableSeq.
>>>>
>>>> The main reason for doing this is to make it easier to allow using
>>>> variables, as the Speaker/Headphones conf files are evaluated after
>>>> the main HiFi.conf had a chance to set them.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>>>
>>> ping? It would be nice to get this series merged for proper SOF
>>> support.
>>>
>>> Maybe this got confused with my other UCM chtnau8824 series which
>>> I send 10 days before t
>>
>> Hi,
>>
>> Thanks for the reminder. I though that this one was resolved. I don't think
>> that we need the first change - the evaluation for If and Include sequences is
>> executed before SectionVerb {} parsing. So the If...Define.RightOutputChannel
>> should be valid for SectionVerb...Include...File
>> "/codecs/nau8824/EnableSeq.conf". The 'DACR Channel Source' control seems to
>> require a static settings so keeping it in the verb init sequence has sense.
>>
>> I applied the second (SST variable) patch for now. It's nice cleanup. Thanks.
> 
> Hans,
> 
> 	could you test https://github.com/alsa-project/alsa-ucm-conf/pull/74 ?

I can confirm that the simplified version from that pull-req works as it should, thanks.

Regards,

Hans