[PATCH] ASoC: ak4458: correct reset polarity

Linus Walleij linus.walleij at linaro.org
Fri Jan 22 23:56:21 CET 2021


Hi Eliot,

thanks for your patch!

On Fri, Jan 22, 2021 at 9:27 AM Eliot Blennerhassett
<eliot at blennerhassett.gen.nz> wrote:

> Reset (aka power off) happens when the reset gpio is made active.
> Change function name to ak4458_reset to match devicetree property "reset-gpios"
>
> Signed-off-by: Eliot Blennerhassett <eliot at blennerhassett.gen.nz>

(...)
> -static void ak4458_power_off(struct ak4458_priv *ak4458)
> +static void ak4458_reset(struct ak4458_priv *ak4458, bool active)

I usually use the variable name "asserted" to be crystal clear as to
what this is about.

With that change:
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij


More information about the Alsa-devel mailing list