[PATCH 4/4] ASoC: qcom: Remove duplicate error messages on ioremap
Stephen Boyd
swboyd at chromium.org
Fri Jan 15 04:43:27 CET 2021
We don't need to print an error message when these ioremap operations
fail. The function that returns an error already prints an error message
and properly attributes it to the device. Drop them to save some code.
Cc: V Sujith Kumar Reddy <vsujithk at codeaurora.org>
Cc: Srinivasa Rao <srivasam at codeaurora.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
Cc: Cheng-Yi Chiang <cychiang at chromium.org>
Signed-off-by: Stephen Boyd <swboyd at chromium.org>
---
sound/soc/qcom/lpass-cpu.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
index b267fe8db3fc..0ca957dcd3fe 100644
--- a/sound/soc/qcom/lpass-cpu.c
+++ b/sound/soc/qcom/lpass-cpu.c
@@ -788,11 +788,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif");
drvdata->lpaif = devm_ioremap_resource(dev, res);
- if (IS_ERR(drvdata->lpaif)) {
- dev_err(dev, "error mapping reg resource: %ld\n",
- PTR_ERR(drvdata->lpaif));
+ if (IS_ERR(drvdata->lpaif))
return PTR_ERR(drvdata->lpaif);
- }
lpass_cpu_regmap_config.max_register = LPAIF_WRDMAPER_REG(variant,
variant->wrdma_channels +
@@ -810,11 +807,8 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev)
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-hdmiif");
drvdata->hdmiif = devm_ioremap_resource(dev, res);
- if (IS_ERR(drvdata->hdmiif)) {
- dev_err(dev, "error mapping reg resource: %ld\n",
- PTR_ERR(drvdata->hdmiif));
+ if (IS_ERR(drvdata->hdmiif))
return PTR_ERR(drvdata->hdmiif);
- }
lpass_hdmi_regmap_config.max_register = LPAIF_HDMI_RDMAPER_REG(variant,
variant->hdmi_rdma_channels);
--
https://chromeos.dev
More information about the Alsa-devel
mailing list