[PATCH v2 1/2] dt-bindings: sound: intel, keembay-i2s: Add info for device to use DMA
Rob Herring
robh at kernel.org
Thu Jan 14 21:42:29 CET 2021
On Fri, Jan 08, 2021 at 11:12:47AM +0800, Michael Sit Wei Hong wrote:
> Add descriptions for entries needed for audio device to use DMA
> channels for audio playback and capture.
Please use get_maintainers.pl so patches go to the right lists.
This binding has errors in linux-next:
./Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml: while parsing a block mapping
in "<unicode string>", line 55, column 9
did not find expected key
in "<unicode string>", line 55, column 27
>
> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit at intel.com>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> ---
> .../bindings/sound/intel,keembay-i2s.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml b/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml
> index d346e61ab708..e0658f122cbb 100644
> --- a/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml
> @@ -45,6 +45,18 @@ properties:
> - const: osc
> - const: apb_clk
>
> + dmas:
> + items:
> + - description: DMA controller phandle and DMA channel
> + for TX and RX
This defines 'dmas' has 1 entry.
> +
> + dma-names:
> + items:
> + - description: "tx" for the transmit channel
The quotes are what cause the above problem.
> + "rx" for the receive channel
> + - const: tx
> + - const: rx
And here dma-names has 3 entries. Drop 'description' because it just
says what the schema defines.
Please send incremental fixes as Mark already applied.
Rob
More information about the Alsa-devel
mailing list