[PATCH 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET

[Guenter Roeck]

On Mon, Jan 11, 2021 at 4:42 PM Mark Brown <broonie at kernel.org> wrote:

> On Fri, Jan 08, 2021 at 12:57:51PM +0800, Yu-Hsuan Hsu wrote:
> > Mark Brown <broonie at kernel.org> 於 2021年1月7日 週四 下午9:55寫道：
>
> > > I think the request was to sync over all the commands that are
> supported
> > > in the EC rather than just split this one addition into a separate
> > > patch.
>
> > Got it. However, after running make_linux_ec_commands_h.sh to create
> > the new cros_ec_commands.h, I found there are lots of difference (1092
> > insertions(+), 66 deletions(-)). In addition, there are also some
> > redefined variables(most are in ./include/linux/usb/pd.h) causing the
> > compile error.
>
> > It seems not easy to sync cros_ec_commands.h. I'm afraid of breaking
> > something. Does anyone have any suggestion? Thanks.
>
> TBH that seems like a big enough change to split out from this and done
> as a separate series, I'd be perfectly happy to apply your original
> change.  I guess part of doing that sync up should ideally be to
> refactor things so that it can be done mechanically in future.
>

Being able to do it mechanically was the idea for introducing the script.
Unfortunately it doesn't help to have such a script if people don't use it.

Guenter