[PATCH] ASoC: hdmi-codec: Fix return value in hdmi_codec_set_jack()

Stephan Gerhold stephan at gerhold.net
Thu Jan 7 17:47:16 CET 2021


On Thu, Jan 07, 2021 at 04:36:00PM +0000, Mark Brown wrote:
> On Thu, Jan 07, 2021 at 05:26:40PM +0100, Stephan Gerhold wrote:
> 
> > However, hdmi_codec_set_jack() returns -E*OP*NOTSUPP if jack detection
> > is not supported, which is not handled in apq8016_sbc and soc_component_ret().
> > Make it return -ENOTSUPP instead to fix sound and silence the errors.
> 
> You will also need to update imx-hdmi, it is explicitly checking for
> -EOPNOTSUPP so this will break it.  Having two error codes with such
> similar names is rather unfortunate.

Right, thanks for mentioning this! Apparently I only checked 5.10 for
other uses of -EOPNOTSUPP... Will send a v2 shortly!

Thanks,
Stephan


More information about the Alsa-devel mailing list