[PATCH 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

Mark Brown broonie at kernel.org
Thu Jan 7 15:27:46 CET 2021


On Thu, Jan 07, 2021 at 05:06:22PM +0800, Chris Chiu wrote:

> +static const struct acpi_gpio_mapping *cht_rt5645_gpios;
> +

You're adding a read only static variable with no way to set it.  This
doesn't actually do anything?

> @@ -3780,7 +3782,6 @@ static const struct dmi_system_id dmi_platform_data[] = {
>  		},
>  		.driver_data = (void *)&intel_braswell_platform_data,
>  	},
> -	{ }
>  };
>  

This is an unrelated change which removes the terminator on the array
which will cause issues.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20210107/507a64c1/attachment.sig>


More information about the Alsa-devel mailing list