[RFC 2/2] ASoC: rt5670: Add LED trigger support

Mark Brown broonie at kernel.org
Thu Feb 25 15:59:02 CET 2021


On Wed, Feb 24, 2021 at 09:09:36PM +0100, Hans de Goede wrote:

> Given that the use of mute LEDs itself is actually rare and especially
> the use of mute LEDs in combination with ASoC coming up with some
> generic configuration mechanism to allow userspace to tie the

This seems like an optimistic set of assumptions - it may reflect
current laptops but it sounds like the sort of thing people might
deploy on future devices, never mind all the non-laptops that could end
up wanting to use this mechanism.

> Not to mention that this would just be punting the actual problem
> of figuring out which control to use to userspace, while the kernel
> is actually in a better place to make this decision since the kernel
> already uses DMI based quirks to deal with model specific configuration.

Again, this only works in cases where there's only one option for the
control that could be used.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20210225/bbe528eb/attachment.sig>


More information about the Alsa-devel mailing list