[PATCH 4/8] ASoC: sh: rcar: core: rename shadowing variables

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Feb 25 00:13:12 CET 2021


Hi Pierre-Louis

> >> sound/soc/sh/rcar/core.c:1369:22: style: Local variable 'rdai' shadows
> >> outer variable [shadowVariable]
> >>      struct rsnd_dai *rdai = rsnd_rdai_get(priv, dai_i);
> >>                       ^
> > 
> > I'm not 100% sure about this warning,
> > but this path is overkill. Maybe below is enough ?
> 
> Hi Morimoto-san,
> It might be better if we drop this patch from the series and have you
> send the proper fix with my Reported-by tag.
> Would that work for you?

OK, thanks.
Will do today

Thank you for your help !!

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list