[PATCH v2 4/6] ASoC: samsung: smdk_wm8994: add missing return

[Sylwester Nawrocki]

On 22.02.2021 22:33, Pierre-Louis Bossart wrote:

> The initial authors bothered to set ret to -EINVAL and throw a
> dev_err() message, so it looks like there is a missing return to avoid
> continuing if the property is missing.
> 
> Reviewed-by: Krzysztof Kozlowski <krzk at kernel.org>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

Reviewed-by: Sylwester Nawrocki <s.nawrocki at samsung.com>

> ---
>  sound/soc/samsung/smdk_wm8994.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c
> index 681b244d5312..39a7a449f554 100644
> --- a/sound/soc/samsung/smdk_wm8994.c
> +++ b/sound/soc/samsung/smdk_wm8994.c
> @@ -164,6 +164,7 @@ static int smdk_audio_probe(struct platform_device *pdev)
>  			dev_err(&pdev->dev,
>  			   "Property 'samsung,i2s-controller' missing or invalid\n");

>  			ret = -EINVAL;
> +			return ret;

I think it would be better to just make it "return -EINVAL;"