[PATCH v2 6/6] ASoC: samsung: tm2_wm5510: remove shadowed variable
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Mon Feb 22 22:33:06 CET 2021
cppcheck warning:
sound/soc/samsung/tm2_wm5110.c:552:26: style: Local variable 'args'
shadows outer variable [shadowVariable]
struct of_phandle_args args;
^
sound/soc/samsung/tm2_wm5110.c:504:25: note: Shadowed declaration
struct of_phandle_args args;
^
sound/soc/samsung/tm2_wm5110.c:552:26: note: Shadow variable
struct of_phandle_args args;
^
Move the top-level variable to the lower scope where it's needed.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
---
sound/soc/samsung/tm2_wm5110.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
index 125e07f65d2b..84c2c63d5a87 100644
--- a/sound/soc/samsung/tm2_wm5110.c
+++ b/sound/soc/samsung/tm2_wm5110.c
@@ -501,7 +501,6 @@ static int tm2_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct snd_soc_card *card = &tm2_card;
struct tm2_machine_priv *priv;
- struct of_phandle_args args;
struct snd_soc_dai_link *dai_link;
int num_codecs, ret, i;
@@ -585,6 +584,8 @@ static int tm2_probe(struct platform_device *pdev)
}
if (num_codecs > 1) {
+ struct of_phandle_args args;
+
/* HDMI DAI link (I2S1) */
i = card->num_links - 1;
--
2.25.1
More information about the Alsa-devel
mailing list