(subset) [PATCH 0/6] ASoC: samsung: remove cppcheck warnings

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon Feb 22 21:39:53 CET 2021



On 2/22/21 2:19 PM, Mark Brown wrote:
> On Mon, Feb 22, 2021 at 06:31:15PM +0100, Krzysztof Kozlowski wrote:
> 
>> Hmmm, I had comments about this one so it should not have been
>> applied. The check if (ret || !args.np) is still not good (or
>> confusing) because args is an uninitialized stack value.
> 
> Ah, I saw the "this is actually a fix CC stable" bit, the bit saying
> there were issues was hidden - it looked like you'd just not deleted
> context.

If you give me about an hour, I can resend a v2 series that includes 
Krzysztof's tags and provides the correct fix for this patch5.


More information about the Alsa-devel mailing list