[PATCH alsa-ucm-conf] codecs/rt5672: Remove Intel SST specific HeadsetMic workaround

Jaroslav Kysela perex at perex.cz
Thu Feb 11 20:16:31 CET 2021


Dne 09. 02. 21 v 22:01 Hans de Goede napsal(a):
> There used to be an issue with the HeadsetMic on BYT devices with
> a rt5672 codec only being recorded on the left channel, while the
> right channel recorded silence.
> 
> The ucm2/codecs/rt5672/HeadsetMic.conf contains a workaround for
> this which changes the SST record-stream demuxer settings to
> use "slot 0" for both the left and right channels when recording
> from the HeadsetMic.
> 
> There are 2 problems with this workaround:
> 
> 1. It uses SST specific mixer settings causing things to break
> when using the SOF driver.
> 
> 2. Files under uc2m/codecs should be architecture agnostic and should
> not depend on platform dependent mixer settings such as the SST driver
> mixer settings.
> 
> The problem which the workaround used to work around has since been
> fixed in the kernel by switching the wire format from TDM/DSP A to I2S:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0ceb8a36d023d4bb4ffca3474a452fb1dfaa0ef2
> 
> This fix has landed in 5.8 and has been backported to all recent
> stable kernel releases.
> 
> Since this is fixed in the kernel now, we can drop the workaround,
> fixing the 2 problems mentioned above.
> 
> This was tested on a ThinkPad 8 tablet, which is the same device as
> where the HeadsetMic problem was originally noticed.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

The patch was applied to the alsa-ucm-conf repository.

					Jaroslav


-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


More information about the Alsa-devel mailing list