[PATCH v4 1/1] ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk
Takashi Iwai
tiwai at suse.de
Fri Feb 5 23:18:17 CET 2021
On Fri, 05 Feb 2021 19:42:56 +0100,
Olivia Mackintosh wrote:
>
> This allows for N different devices to use the pioneer mixer quirk for
> setting capture/record type and recording level. The impementation has
> not changed much with the exception of an additional mask on
> private_value to allow storing of a device index:
> DEVICE MASK 0xff000000
> GROUP_MASK 0x00ff0000
> VALUE_MASK 0x0000ffff
>
> This could be improved by changing the arrays of wValues for each
> channel to contain named definitions (e.g. SND_DJM_CAP_LINE). It would
> improve readability and perhaps would allow using the same array for
> multiple channels. The channel number can be specified on the control
> next to the wIndex.
>
> Feedback is very much appreciated as I'm not the most proficient C
> programmer but am learning as I go.
>
> Signed-off-by: Olivia Mackintosh <livvy at base.nu>
Thanks, applied now.
Takashi
More information about the Alsa-devel
mailing list