[PATCH 14/14] ASoC: SOF: Intel: hda: add dev_dbg() when DMIC number is overridden

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Fri Feb 5 16:47:39 CET 2021



On 2/5/21 9:33 AM, Mark Brown wrote:
> On Thu, Feb 04, 2021 at 02:33:12PM -0600, Pierre-Louis Bossart wrote:
> 
>>   	/* allow for module parameter override */
>> -	if (hda_dmic_num != -1)
>> +	if (hda_dmic_num != -1) {
> 
> This is breaking in an x86 allmodconfig build due to:
> 
> /mnt/kernel/sound/soc/sof/intel/hda.c: In function 'dmic_topology_fixup':
> /mnt/kernel/sound/soc/sof/intel/hda.c:615:6: error: 'hda_dmic_num' undeclared (first use in this function); did you mean 'dmic_num'?
>    if (hda_dmic_num != -1) {
>        ^~~~~~~~~~~~
>        dmic_num
> /mnt/kernel/sound/soc/sof/intel/hda.c:615:6: note: each undeclared identifier is reported only once for each function it appears in
> 
> which will actually be triggered by one of the earlier patches in the
> series (my script is going through things in reverse order), that
> variable is only defined for CONFIG_SOC_SOF_HDA.

That's not good. Please drop this patch for now, it's nice-to-have and 
not critical.

I'll have to figure out why this wasn't reported earlier.


More information about the Alsa-devel mailing list