[PATCH v5 3/5] ALSA: usb-audio: Avoid unnecessary interface re-setup

[Takashi Iwai]

On Thu, 04 Feb 2021 22:44:00 +0100,
Pierre-Louis Bossart wrote:
> 
> 
> 
> >   /**
> > - * snd_usb_endpoint_free: Free the resources of an snd_usb_endpoint
> > + * snd_usb_endpoint_free_all: Free the resources of an snd_usb_endpoint
> > + * @card: The chip
> >    *
> > - * @ep: the endpoint to free
> > - *
> > - * This free all resources of the given ep.
> > + * This free all endpoints and those resources
> >    */
> > -void snd_usb_endpoint_free(struct snd_usb_endpoint *ep)
> > +void snd_usb_endpoint_free_all(struct snd_usb_audio *chip)
> 
> this causes warnings with make sound/ W=1
> 
>   CC [M]  sound/usb/endpoint.o
> sound/usb/endpoint.c:1459: warning: Function parameter or member
> 'chip' not described in 'snd_usb_endpoint_free_all'
> sound/usb/endpoint.c:1459: warning: Excess function parameter 'card'
> description in 'snd_usb_endpoint_free_all'
> 
> the following diff removes it, but I don't know if the description is
> good enough...
> 
> diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
> index 8e568823c992..4d1c678a0d80 100644
> --- a/sound/usb/endpoint.c
> +++ b/sound/usb/endpoint.c
> @@ -1451,7 +1451,7 @@ void snd_usb_endpoint_release(struct
> snd_usb_endpoint *ep)
> 
>  /**
>   * snd_usb_endpoint_free_all: Free the resources of an snd_usb_endpoint
> - * @card: The chip
> + * @chip: The chip
>   *
>   * This free all endpoints and those resources
>   */

Thanks, I'll queue the fix.


Takashi