[PATCH] mips: lantiq: add support for clk_set_parent()

Jonathan Cameron jic23 at kernel.org
Wed Dec 29 17:39:08 CET 2021


On Tue, 28 Dec 2021 16:03:45 -0800
Randy Dunlap <rdunlap at infradead.org> wrote:

> Provide a simple implementation of clk_set_parent() in the lantiq
> subarch so that callers of it will build without errors.
> 
> Fixes these build errors:
> 
> ERROR: modpost: "clk_set_parent" [sound/soc/jz4740/snd-soc-jz4740-i2s.ko] undefined!
> ERROR: modpost: "clk_set_parent" [sound/soc/atmel/snd-soc-atmel-i2s.ko] undefined!
> 
> Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Reported-by: kernel test robot <lkp at intel.com>
> --to=linux-mips at vger.kernel.org --cc="John Crispin <john at phrozen.org>" --cc="Jonathan Cameron <jic23 at kernel.org>" --cc="Russell King <linux at armlinux.org.uk>" --cc="Andy Shevchenko <andy.shevchenko at gmail.com>" --cc=alsa-devel at alsa-project.org --to="Thomas Bogendoerfer <tsbogend at alpha.franken.de>"

I guess hitting this sooner or later was inevitable given the recent fix
of adding clk_get_parent() to these two.  It might be worth adding a
WARN_ON() or similar to this function though so we know if anything
ever actually hits it at runtime.  Seems like at least some of the
other similar stubs do so (omap1 for example).

With or without a warning, LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron at huawei.com>

> ---
>  arch/mips/lantiq/clk.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> --- linux-next-20211224.orig/arch/mips/lantiq/clk.c
> +++ linux-next-20211224/arch/mips/lantiq/clk.c
> @@ -164,6 +164,12 @@ struct clk *clk_get_parent(struct clk *c
>  }
>  EXPORT_SYMBOL(clk_get_parent);
>  
> +int clk_set_parent(struct clk *clk, struct clk *parent)
> +{
> +	return 0;
> +}
> +EXPORT_SYMBOL(clk_set_parent);
> +
>  static inline u32 get_counter_resolution(void)
>  {
>  	u32 res;



More information about the Alsa-devel mailing list