[PATCH 1/2] ALSA/ASoC: hda: move/rename snd_hdac_ext_stop_streams to hdac_stream.c

Cezary Rojewski cezary.rojewski at intel.com
Fri Dec 17 10:18:29 CET 2021


On 2021-12-17 12:11 AM, Pierre-Louis Bossart wrote:
> snd_hdac_ext_stop_streams() has really nothing to do with the
> extension, it just loops over the bus streams.
> 
> Move it to the hdac_stream layer and rename to remove the 'ext'
> prefix and add the precision that the chip will also be stopped.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> Reviewed-by: Kai Vehmanen <kai.vehmanen at intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi at linux.intel.com>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan at linux.intel.com>

Change looks good. I wonder though, if there is a better 'name' for the 
process (here, stop streams + stop chip as a tear down process) than 
'stop_streams_and_chip'.

Reviewed-by: Cezary Rojewski <cezary.rojewski at intel.com>


More information about the Alsa-devel mailing list