[PATCH 4/5] ASoC: Intel: catpt: Drop SND_SOC_ACPI_INTEL_MATCH dependency

Cezary Rojewski cezary.rojewski at intel.com
Fri Dec 17 10:06:19 CET 2021


On 2021-12-16 7:04 PM, Pierre-Louis Bossart wrote:

...

>> Hmm.. doesn't it really? Are the glk/cnl/cfl/cml/icl/jsl/tgl/ehl/adl
>> tables "common" for the Intel audio drivers? There are not used by
>> anything except for SOF. It seems reasonable to have them present
>> locally too. SOF solution becomes more cohesively organized in such
>> case, just like catpt is after this patch.
> 
> We could also move the boards/ while we're at it, on the grounds they
> are not all used by all drivers.
> 
> My take is that unless a new feature is added that warrants moving the
> tables around, let's keep the existing code as is.
> 

I agree with the relocation of the boards! In general, improving the 
maintainability is worth it, even if it takes a larger number of patches.

Hmm.. avs-driver related boards are kind of an argument in this 
discussion. I can delay patches 4/5 and 5/5 until they're on the list, 
no problem.


Mark,

Should I re-send the series as 3, or is it fine as is and simply last 
two patches could be omitted?


Regards,
Czarek


More information about the Alsa-devel mailing list