[PATCH] SoC: qcom: Distinguish headset codec by codec_dai->name

Mark Brown broonie at kernel.org
Mon Dec 13 19:00:35 CET 2021


On Fri, Dec 10, 2021 at 03:15:49PM -0800, Stephen Boyd wrote:
> Quoting Judy Hsiao (2021-12-09 21:19:07)

> > Fixes: 425c5fce8a03 ("ASoC: qcom: Add support for ALC5682I-VS codec")

> It fixes something so what is it fixing? Can you add the call stack of
> the failure and explain how this patch fixes it? We have that patch
> backported to our chromeos 5.4 kernel tree but I assume this reproduces
> upstream.

Please don't encourage people to just paste entire panics into things,
what you've included here is vastly larger than the entire original
patch which overwhelms the content in the message.

>  Unable to handle kernel paging request at virtual address ffffffbfe7bba9ce
>  Mem abort info:
>    ESR = 0x96000005
>    EC = 0x25: DABT (current EL), IL = 32 bits
>    SET = 0, FnV = 0
>    EA = 0, S1PTW = 0
>  Data abort info:
>    ISV = 0, ISS = 0x00000005
>    CM = 0, WnR = 0

Information like the above or the register contents is not adding any
value here, it just makes it harder to find the actual content in the
message.  Sometimes a relevant portion of the stack can be useful but
that's not what's happening here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20211213/84fa531a/attachment.sig>


More information about the Alsa-devel mailing list