[bug report] ASoC: rsnd: adg: clearly handle clock error / NULL case
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Wed Aug 25 00:55:56 CEST 2021
Hi Dan
Thank you for your feedback
> sound/soc/sh/rcar/adg.c:396 rsnd_adg_create_null_clk()
> warn: passing zero to 'ERR_CAST'
(snip)
> The clk_register_fixed_rate() function doesn't have any documentation,
> but generally when functions return a mix of error pointers and NULL
> then the NULL case means the feature is deliberately disabled. So it
> should not print an error message. Perhaps an info message at most.
>
> --> 396 return ERR_CAST(clk);
>
> No need to cast this. The types are the same.
Thanks. Will fix these in next week.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
More information about the Alsa-devel
mailing list