[PATCH v2] ASoC: Intel: Fix platform ID matching for kbl_da7219_max98373
Cezary Rojewski
cezary.rojewski at intel.com
Thu Aug 19 17:06:47 CEST 2021
On 2021-08-19 4:30 PM, Pierre-Louis Bossart wrote:
> On 8/19/21 3:24 AM, Lukasz Majczak wrote:
>> Sparse warnings triggered truncating the IDs of some platform device
>> tables. Unfortunately kbl_da7219_max98373 was also truncated.
>> This patch is reverting the original ID.
>> Tested on Atlas chromebook.
>
> Instead of reverting, how about changing the remaining occurrences of
> the old name in the machine driver?
>
> sound/soc/intel/boards/kbl_da7219_max98927.c: if (!strcmp(pdev->name,
> "kbl_da7219_max98373") ||
> sound/soc/intel/boards/kbl_da7219_max98927.c: .name =
> "kbl_da7219_max98373",
Mentioned by 'Fixes' tag patch clearly introduced regression. If we are
to update any name-fields, it's better to have a fresh start and update
all the boards in one-go than doing so separately.
Apart from that, Maxim codecs go by the name of 'max' in
sound/soc/codecs/. It's more intuitive to have equivalent shortcut used
in board's name.
Regards,
Czarek
More information about the Alsa-devel
mailing list