[PATCH] ASoC: Intel: bytcr_rt5640: Use cfg-lineout:2 in the components string
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Mon Aug 16 15:32:59 CEST 2021
On 8/16/21 6:47 AM, Hans de Goede wrote:
> Use "cfg-lineout:2" in the components string on boards with a lineout
> instead of "cfg-lineout:1", this better mirrors the speaker part of
> the components string where we use "cfg-spk:1" for devices with a single
> speaker and "cfg-spk:2" for stereo speakers.
>
> The lineout is stereo by default, so using ":2" makes more sense, this
> way we keep ":1" reserved in case we ever encounter a device with
> a mono lineout.
>
> We can make this change without breaking userspace because no kernel
> has shipped with "cfg-lineout:1" in the component-string yet; and there
> also are no userspace bits (UCM profiles) checking for this yet.
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 369642c07a5d..f79234f49c7c 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -1688,7 +1688,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
> if (byt_rt5640_quirk & BYT_RT5640_LINEOUT_AS_HP2)
> lineout_string = " cfg-hp2:lineout";
> else
> - lineout_string = " cfg-lineout:1";
> + lineout_string = " cfg-lineout:2";
> }
>
> if (byt_rt5640_quirk & BYT_RT5640_HSMIC2_ON_IN1)
>
More information about the Alsa-devel
mailing list