[PATCH v2] ASoC: Intel: Fix platform ID matching

Curtis Malainey cujomalainey at google.com
Wed Aug 11 01:40:30 CEST 2021


On Tue, Aug 10, 2021 at 5:23 AM Cezary Rojewski
<cezary.rojewski at intel.com> wrote:
>
> On 2021-08-09 11:35 PM, Curtis Malainey wrote:
> > Sparse warnings triggered truncating the IDs of some platform device
> > tables. Unfortunately some of the IDs in the match tables were missed
> > which breaks audio. The KBL change has been verified to fix audio, the
> > CML change was not tested as it was found through grepping the broken
> > changes and found to match the same situation in anticipation that it
> > should also be fixed.
> >
> > Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters")
> > Fixes: 24e46fb811e9 ("ASoC: Intel: bxt_da7219_max98357a: shrink platform_id below 20 characters")
> > Signed-off-by: Curtis Malainey <cujomalainey at chromium.org>
> > Tested-by: Matt Davis <mattedavis at google.com>
>
> Thanks for the update, Curtis.
>
> This is still missing Suggested-by tag from my previous review.
> As kbl bits were tested by Lukasz it would be good to have his Tested-by
> tag too.
>
> With said tags appended:
>
> Reviewed-by: Cezary Rojewski <cezary.rojewski at intel.com>

Ah i was not privy to that patch, this bug was found independently on
another board. Thanks for the heads up though.

>
>
> Regards,
> Czarek


More information about the Alsa-devel mailing list