[PATCH v3 13/20] ASoC: qdsp6: audioreach: add basic pkt alloc support

[Srinivas Kandagatla]

Thanks Amadeusz for review,

On 03/08/2021 15:19, Amadeusz Sławiński wrote:
> On 8/3/2021 2:54 PM, Srinivas Kandagatla wrote:
>> Add basic helper functions for AudioReach.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
>> ---
> 
> ...
> 
>> +
>> +#define APM_PARAM_ID_GAIN            0x08001006
>> +struct param_id_gain_cfg {
>> +    uint16_t gain;
>> +    uint16_t reserved;
>> +};
>> +
>> +#define PARAM_ID_PCM_OUTPUT_FORMAT_CFG        0x08001008
>> +struct param_id_pcm_output_format_cfg {
>> +    uint32_t data_format;
>> +    uint32_t fmt_id;
>> +    uint32_t payload_size;
>> +} __packed;
>> +
>> +struct payload_pcm_output_format_cfg {
>> +    uint16_t bit_width;
>> +    uint16_t alignment;
>> +    uint16_t bits_per_sample;
>> +    uint16_t q_factor;
>> +    uint16_t endianness;
>> +    uint16_t interleaved;
>> +    uint16_t reserved;
>> +    uint16_t num_channels;
>> +    uint8_t channel_mapping[0];
> 
> Current kernel convention is to use something like:
> uint8_t channel_mapping[];
> for flexible arrays.
> I've pointed out few more later, but it would be best to run some kind 
> of search to find them all in all files in patchset.

I agree, will search and fix such instances.

--srini