[PATCH] ALSA: hda/realtek: add mic quirk for Acer SF314-42

Takashi Iwai tiwai at suse.de
Sun Aug 1 09:39:13 CEST 2021


On Sun, 01 Aug 2021 09:00:48 +0200,
Alexander Monakov wrote:
> 
> On Sun, 1 Aug 2021, Nikos Liolios wrote:
> 
> > Other quirks for Acer Swift (for Acer SWIFT SF314-54/55/56) they describe the
> > model using capital letters ("SWIFT" instead of "Swift").  I do think that
> > "Swift" is better than (caps locked) "SWIFT". Thinking to create a patch for
> > it since I helped to create this mess.  From my understanding it only affects
> > the dmesg of which quirk was used, nothing important, but lets keep code
> > clean.
> > 
> > What do you think? Rename "SWIFT"s to "Swift"s?
> > If no disagreement or no reply I am doing it like tomorrow.
> 
> I agree "Swift" would be better: as far as I can tell, Acer mostly uses "Swift"
> (both in marketing materials and DMI information). I would support the rename.

That's a really bikeshed topic, and I don't think we need an extra
patch to correct it.  The message is only for debug prints, usually
you don't see it.


thanks,

Takashi


More information about the Alsa-devel mailing list