[PATCH v1 05/14] spi: pxa2xx: Consolidate related headers under include/linux/spi
Mark Brown
broonie at kernel.org
Fri Apr 23 19:49:25 CEST 2021
On Fri, Apr 23, 2021 at 08:30:08PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 23, 2021 at 05:56:30PM +0100, Mark Brown wrote:
> > On Fri, Apr 23, 2021 at 07:34:28PM +0300, Andy Shevchenko wrote:
> > > We have two headers split between include/linux and include/linux/spi.
> > > Consolidated them under SPI realm, i.e. in the latter folder.
> > Why? Isn't the point to maintain an abstraction between the general
> > purpose use of the SSP IP and its application as a SPI controller?
> Aren't the General Purpose of the SSP IP is an SPI controller either way?
> What you are talking about is probably GP SPI vs. private (dedicated) SPI.
SPI and any other serial protocols that happen to come up - these
generic serial IPs also often get used for audio for example.
> > I'd
> > check the cover letter for the series but there doesn't seem to be one.
> Set of cleanups here and there related to the SPI PXA2xx driver.
> It's hard to add something else here.
It doesn't need to be much more than what you just wrote.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20210423/a9645c3b/attachment-0001.sig>
More information about the Alsa-devel
mailing list