[PATCH 0/5] ASoC: rt286/rt298: Fixes for DMIC2 config and combo jack

[Pierre-Louis Bossart]

On 4/18/21 8:46 AM, David Ward wrote:
> The last two patches in this series fix a longstanding issue that prevented
> the ALC3263 codec from using a headset mic. This codec can be found on Dell
> systems including the Latitude 13 7350, Venue 11 Pro 7140, and XPS 13 9343.
> In fact, there is an ACPI quirk for the XPS 13 9343, which forces it to use
> legacy HD Audio just to avoid this issue:
> 
> https://lore.kernel.org/alsa-devel/CAPeXnHv07HkvcHrYFmZMr8OTp7U7F=k_k=LPYnUtp89iPn2d2Q@mail.gmail.com/
> 
> This may allow that ACPI quirk to be removed. Either way, the other systems
> mentioned above do not support this quirk and already use the ASoC driver,
> so this fix is necessary for headset mic support on those systems.

You should probably add a Fixes tag for the 5 patches so that the 
changes make their way into the -stable kernel that most distributions use?

The patches themselves look ok to me

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

> 
> Note: there is likely other handling for this codec that only exists in the
> HDA driver, but which also belongs in the ASoC driver. Commit 394c97f824fa
> ("ALSA: hda/realtek - Change EAPD to verb control") describes an issue that
> does not seem to be resolved in the ASoC driver, to give an example.
> 
> 
> Other patches in this series are not specific to the ALC3263. These patches
> set the correct combo jack configuration when headphones are inserted, and
> fix a misaligned value set in the DMIC2 Configuration Default register.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=114171
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=150601
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205961
> Signed-off-by: David Ward <david.ward at gatech.edu>
> 
> David Ward (5):
>    ASoC: rt286: Fix upper byte in DMIC2 configuration
>    ASoC: rt286: Configure combo jack for headphones
>    ASoC: rt298: Configure combo jack for headphones
>    ASoC: rt286: Make RT286_SET_GPIO_* readable and writable
>    ASoC: rt286: Generalize support for ALC3263 codec
> 
>   sound/soc/codecs/rt286.c | 34 +++++++++++++++++++++-------------
>   sound/soc/codecs/rt298.c |  9 +++++++--
>   2 files changed, 28 insertions(+), 15 deletions(-)
>