[PATCH] ASoC: rt711-sdca: remove capture switch controls

[Jaroslav Kysela]

Dne 19. 04. 21 v 7:14 Yang, Libin napsal(a):
> Hi Pierre,
> 
> 
>> -----Original Message-----
>> From: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
>> Sent: 2021年4月15日 19:26
>> To: shumingf at realtek.com; broonie at kernel.org; lgirdwood at gmail.com
>> Cc: oder_chiou at realtek.com; jack.yu at realtek.com; alsa-devel at alsa-
>> project.org; lars at metafoo.de; Yang, Libin <libin.yang at intel.com>;
>> derek.fang at realtek.com; flove at realtek.com
>> Subject: Re: [PATCH] ASoC: rt711-sdca: remove capture switch controls
>>
>>
>>
>> On 4/15/21 4:16 AM, shumingf at realtek.com wrote:
>>> From: Shuming Fan <shumingf at realtek.com>
>>>
>>> The settings of the switch control already set by DAPM event.
>>> These switch controls might the user confused why it can't disable the
>> capture.
>>
>> Sorry, not following. This control is used in the alsa-ucm-conf that was just
>> merged
>>
>> https://github.com/alsa-project/alsa-ucm-
>> conf/commit/197025656ec456331d1a34357b113913ec3b187f#diff-
>> 0e1c627ea89ee148fdb41aa6b3ba7851ba9c20eb43c1b87b9e0ce92164273dc3R
>> 7
>>
>> Is this saying this commit needs to be fixed with a follow-up PR? Libin, are
>> you working on this?
> 
> Yes, I will submit a patch for UCM after this patch is merged.
> 
> The background is Jaroslav requires using codec HW kcontrol for capture
> volume/switch. Shuming and I worked on it. At first we wanted to use
> FU0F to replace PGA kcontrol. But Shuming found FU0F is used in DAPM.
> So it is not proper for the capture volume/switch. And Shuming will remove
> the FU0F kcontrol.

Is switch control name aligned with the volume control name after this change?
I mean "A Capture Switch" + "A Capture Volume" not "A Capture Switch" + "B
Capture Volume".

						Jaroslav

> 
> Regards,
> Libin
> 
>>
>>
>>>
>>> Signed-off-by: Shuming Fan <shumingf at realtek.com>
>>> ---
>>>   sound/soc/codecs/rt711-sdca.c | 8 --------
>>>   1 file changed, 8 deletions(-)
>>>
>>> diff --git a/sound/soc/codecs/rt711-sdca.c b/sound/soc/codecs/rt711-
>> sdca.c
>>> index bfb7f1c8ec8f..2a09c305f4e4 100644
>>> --- a/sound/soc/codecs/rt711-sdca.c
>>> +++ b/sound/soc/codecs/rt711-sdca.c
>>> @@ -652,14 +652,6 @@ static const struct snd_kcontrol_new
>> rt711_sdca_snd_controls[] = {
>>>   		SDW_SDCA_CTL(FUNC_NUM_JACK_CODEC,
>> RT711_SDCA_ENT_USER_FU05, RT711_SDCA_CTL_FU_VOLUME, CH_R),
>>>   		0x57, 0x57, 0,
>>>   		rt711_sdca_set_gain_get, rt711_sdca_set_gain_put,
>> out_vol_tlv),
>>> -	SOC_DOUBLE_R("FU1E Capture Switch",
>>> -		SDW_SDCA_CTL(FUNC_NUM_MIC_ARRAY,
>> RT711_SDCA_ENT_USER_FU1E, RT711_SDCA_CTL_FU_MUTE, CH_L),
>>> -		SDW_SDCA_CTL(FUNC_NUM_MIC_ARRAY,
>> RT711_SDCA_ENT_USER_FU1E, RT711_SDCA_CTL_FU_MUTE, CH_R),
>>> -		0, 1, 1),
>>> -	SOC_DOUBLE_R("FU0F Capture Switch",
>>> -		SDW_SDCA_CTL(FUNC_NUM_JACK_CODEC,
>> RT711_SDCA_ENT_USER_FU0F, RT711_SDCA_CTL_FU_MUTE, CH_L),
>>> -		SDW_SDCA_CTL(FUNC_NUM_JACK_CODEC,
>> RT711_SDCA_ENT_USER_FU0F, RT711_SDCA_CTL_FU_MUTE, CH_R),
>>> -		0, 1, 1),
>>>   	SOC_DOUBLE_R_EXT_TLV("FU1E Capture Volume",
>>>   		SDW_SDCA_CTL(FUNC_NUM_MIC_ARRAY,
>> RT711_SDCA_ENT_USER_FU1E, RT711_SDCA_CTL_FU_VOLUME, CH_L),
>>>   		SDW_SDCA_CTL(FUNC_NUM_MIC_ARRAY,
>> RT711_SDCA_ENT_USER_FU1E, RT711_SDCA_CTL_FU_VOLUME, CH_R),
>>>


-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.