[PATCH] ALSA: seq: oss: Fix inconsistent indenting

Takashi Iwai tiwai at suse.de
Fri Apr 16 12:41:57 CEST 2021


On Fri, 16 Apr 2021 12:00:44 +0200,
Yang Li wrote:
> 
> Kernel test robot throws below warning ->
> 
> smatch warnings:
> sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn:
> inconsistent indenting
> 
> Fixed the inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci at linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee at linux.alibaba.com>
> ---
>  sound/core/seq/oss/seq_oss_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c
> index 7b7c925..9a42713 100644
> --- a/sound/core/seq/oss/seq_oss_event.c
> +++ b/sound/core/seq/oss/seq_oss_event.c
> @@ -294,7 +294,7 @@
>  				/* set volume to zero -- note off */
>  			//	type = SNDRV_SEQ_EVENT_NOTEOFF;
>  			//else
> -				if (info->ch[ch].vel)
> +			if (info->ch[ch].vel)
>  				/* sample already started -- volume change */
>  				type = SNDRV_SEQ_EVENT_KEYPRESS;

The line was aligned with the commented if block.
If any, we should rather clean up and re-format the whole block.
(But, OTOH, you shouldn't remove the stuff without understanding
the context.)


thanks,

Takashi


More information about the Alsa-devel mailing list