[PATCH] ALSA: control_led - fix the stack usage (control element ops)

Takashi Iwai tiwai at suse.de
Wed Apr 14 14:23:46 CEST 2021


On Wed, 14 Apr 2021 12:58:58 +0200,
Jaroslav Kysela wrote:
> 
> It's a bad idea to allocate big structures on the stack.
> Mark the variables as static and add a note for the locking.
> 
> Fixes: 22d8de62f11b ("ALSA: control - add generic LED trigger module as the new control layer")
> Signed-off-by: Jaroslav Kysela <perex at perex.cz>
> Cc: Nathan Chancellor <nathan at kernel.org>
> Cc: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> Signed-off-by: Jaroslav Kysela <perex at perex.cz>

Applied now (with a removal of the duplicated sign-off).

Thanks!


Takashi


More information about the Alsa-devel mailing list