Implicit feedback on BOSS GT-1, the saga continues...

[Mike Oliphant]

Lucas - yes, the issue that occurs is that you get sporadic small pops or
clicks in the audio stream.

Mike

On Wed, Apr 7, 2021 at 1:24 PM Mike Oliphant <oliphant at nostatic.org> wrote:

> Hi Lucas,
>
> These are the changes I have made for the GT-1. Note that I also disabled
> the capture implicit feedback since it does not seem to be needed (although
> it still works for me if it is enabled).
>
> If you think about it, it makes sense that playback is using capture for
> implicit feedback, and not vice versa.
>
> Mike
>
> ---
>
> diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
> index 102d53515..99d8b50d4 100644
> --- a/sound/usb/endpoint.c
> +++ b/sound/usb/endpoint.c
> @@ -1375,7 +1375,7 @@ int snd_usb_endpoint_start(struct snd_usb_endpoint
> *ep)
>         if (!ep_state_update(ep, EP_STATE_STOPPED, EP_STATE_RUNNING))
>                 goto __error;
>
> -       if (snd_usb_endpoint_implicit_feedback_sink(ep)) {
> +       if (false) { //snd_usb_endpoint_implicit_feedback_sink(ep)) {
>                 for (i = 0; i < ep->nurbs; i++) {
>                         struct snd_urb_ctx *ctx = ep->urb + i;
>                         list_add_tail(&ctx->ready_list,
> &ep->ready_playback_urbs);
> diff --git a/sound/usb/implicit.c b/sound/usb/implicit.c
> index 11a85e66a..ee4243421 100644
> --- a/sound/usb/implicit.c
> +++ b/sound/usb/implicit.c
> @@ -75,7 +75,7 @@ static const struct snd_usb_implicit_fb_match
> playback_implicit_fb_quirks[] = {
>         IMPLICIT_FB_SKIP_DEV(0x0582, 0x0171),   /* BOSS RC-505 */
>         IMPLICIT_FB_SKIP_DEV(0x0582, 0x0185),   /* BOSS GP-10 */
>         IMPLICIT_FB_SKIP_DEV(0x0582, 0x0189),   /* BOSS GT-100v2 */
> -       IMPLICIT_FB_SKIP_DEV(0x0582, 0x01d6),   /* BOSS GT-1 */
> +       IMPLICIT_FB_GENERIC_DEV(0x0582, 0x01d6),        /* BOSS GT-1 */
>         IMPLICIT_FB_SKIP_DEV(0x0582, 0x01d8),   /* BOSS Katana */
>         IMPLICIT_FB_SKIP_DEV(0x0582, 0x01e5),   /* BOSS GT-001 */
>         IMPLICIT_FB_SKIP_DEV(0x0582, 0x0203),   /* BOSS AD-10 */
> @@ -89,7 +89,7 @@ static const struct snd_usb_implicit_fb_match
> capture_implicit_fb_quirks[] = {
>         IMPLICIT_FB_FIXED_DEV(0x0582, 0x0171, 0x0d, 0x01), /* BOSS RC-505
> */
>         IMPLICIT_FB_FIXED_DEV(0x0582, 0x0185, 0x0d, 0x01), /* BOSS GP-10 */
>         IMPLICIT_FB_FIXED_DEV(0x0582, 0x0189, 0x0d, 0x01), /* BOSS
> GT-100v2 */
> -       IMPLICIT_FB_FIXED_DEV(0x0582, 0x01d6, 0x0d, 0x01), /* BOSS GT-1 */
> +//     IMPLICIT_FB_FIXED_DEV(0x0582, 0x01d6, 0x0d, 0x01), /* BOSS GT-1 */
>         IMPLICIT_FB_FIXED_DEV(0x0582, 0x01d8, 0x0d, 0x01), /* BOSS Katana
> */
>         IMPLICIT_FB_FIXED_DEV(0x0582, 0x01e5, 0x0d, 0x01), /* BOSS GT-001
> */
>         IMPLICIT_FB_FIXED_DEV(0x0582, 0x0203, 0x0d, 0x01), /* BOSS AD-10 */
>
> On Wed, Apr 7, 2021 at 1:18 PM Lucas <jaffa225man at gmail.com> wrote:
>
>> I didn't notice anything wrong when I added my Roland device IDs to your
>> patch's method.  Its information can be found here, but I really doubt it
>> applies to your issue, other than Takashi Iwai's simplified
>> capture-quirk-only table patch (which Geraldo already mentioned):
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=212519
>>
>> Since I built my patch upon your previous patch, is there anything I can
>> do to test it on my devices for you?
>>
>