[PATCH v3 2/2] soundwire: sysfs: add slave status and device number before probe

Greg KH gregkh at linuxfoundation.org
Fri Sep 25 07:18:50 CEST 2020


On Thu, Sep 24, 2020 at 02:44:30PM -0500, Pierre-Louis Bossart wrote:
> The MIPI DisCo device properties that are read by the driver from
> platform firmware, or hard-coded in the driver, should only be
> provided as sysfs entries when a driver probes successfully.
> 
> However the device status and device number is updated even when there
> is no driver present, and hence can be updated when a Slave device is
> detected on the bus without being described in platform firmware and
> without any driver registered/probed.
> 
> As suggested by GregKH, the attribute group for Slave status and
> device number is is added by default upon device registration.
> 
> Credits to Vinod Koul for the status_show() function, shared in a
> separate patch and used as is here. The status table was modified to
> remove an unnecessary enum and status_show() is handled in a different
> group attribute than what was suggested by Vinod.
> 
> Tested-by: Srinivas Kandgatla <srinivas.kandagatla at linaro.org>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> Co-developed-by: Vinod Koul <vkoul at kernel.org>
> Signed-off-by: Vinod Koul <vkoul at kernel.org>
> ---

Reviewed-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>


More information about the Alsa-devel mailing list