[PATCH] ALSA: hda - add missing documentation to hdac_i915

Kai Vehmanen kai.vehmanen at linux.intel.com
Thu Sep 24 18:10:19 CEST 2020


Hey,

On Thu, 24 Sep 2020, Takashi Iwai wrote:

> On Thu, 24 Sep 2020 17:40:43 +0200, Kai Vehmanen wrote:
> > Document missing function arguments and fix make W=1
> > warning:
> 
> Do we really need to put this internal function in the API documents?
> If not, the right fix would be to drop the kerneldoc marker instead.

I was puzzled at this as well. I took a look at some static internal
functions and there were both with (e.g. snd_hdac_make_cmd()) and without 
kerneldoc markers. But, but, granted, this is without any name prefix, so 
maybe better to drop the kerneldoc. Let me send a v2.

Br, Kai



More information about the Alsa-devel mailing list