[PATCH 5/6] ASoC: Intel: sof_sdw_rt700: add codec prefix

[Jaroslav Kysela]

Dne 23. 09. 20 v 11:25 Kai Vehmanen napsal(a):
> Hi,
> 
> On Wed, 23 Sep 2020, Jaroslav Kysela wrote:
> 
>> Dne 23. 09. 20 v 10:05 Kai Vehmanen napsal(a):
>>> From: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
>>> --- a/sound/soc/intel/boards/sof_sdw_rt700.c
>>> +++ b/sound/soc/intel/boards/sof_sdw_rt700.c
>>> @@ -23,9 +23,9 @@ static const struct snd_soc_dapm_widget rt700_widgets[] = {
>>>  
>>>  static const struct snd_soc_dapm_route rt700_map[] = {
>>>  	/* Headphones */
>>> -	{ "Headphones", NULL, "HP" },
>>> -	{ "Speaker", NULL, "SPK" },
>>> -	{ "MIC2", NULL, "AMIC" },
>>> +	{ "Headphones", NULL, "rt700 HP" },
>>> +	{ "Speaker", NULL, "rt700 SPK" },
>>
>>> +	{ "rt700 MIC2", NULL, "AMIC" },
>>
>> This line looks suspicious. Perhaps, the prefix should be added before AMIC ?
> 
> I believe this is still correct. We prefix the codec-side entry of the 
> dapm routes with codec string and here MIC2 is the codec. This is aligned 
> with existing code for 711 in sof_sdw_rt711.c:
> 
> static const struct snd_soc_dapm_route rt711_map[] = {
> »       /* Headphones */
> »       { "Headphone", NULL, "rt711 HP" },
> »       { "rt711 MIC2", NULL, "Headset Mic" },
> };
> 
> Br, Kai
> 

Ok, thanks for the clarification.

				Jaroslav

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.