[PATCH v3 04/11] USB: core: hub.c: use usb_control_msg_send() in a few places

Greg Kroah-Hartman gregkh at linuxfoundation.org
Wed Sep 16 11:06:41 CEST 2020


On Mon, Sep 14, 2020 at 02:06:16PM -0400, Alan Stern wrote:
> On Mon, Sep 14, 2020 at 05:37:49PM +0200, Greg Kroah-Hartman wrote:
> > There are a few calls to usb_control_msg() that can be converted to use
> > usb_control_msg_send() instead, so do that in order to make the error
> > checking a bit simpler and the code smaller.
> > 
> > Cc: Alan Stern <stern at rowland.harvard.edu>
> > Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> > ---
> > v3:
> >  - drop change in usb_enable_link_state() as it was not needed now
> >    thanks to review from Alan
> >  - minor changes requested by checkpatch.pl
> > 
> > v2:
> >  - dropped changes to usb_req_set_sel() thanks to review from Alan
> > 
> >  drivers/usb/core/hub.c | 99 +++++++++++++++++-------------------------
> >  1 file changed, 40 insertions(+), 59 deletions(-)
> 
> Reviewed-by: Alan Stern <stern at rowland.harvard.edu>

Thanks for the review!

greg k-h


More information about the Alsa-devel mailing list