[PATCH 1/2] ASoC: soc-compress: tidyup STREAM vs COMPRESS

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Fri Oct 30 01:48:45 CET 2020


Hi

> > > Right, such uapi can't be removed.
> > >
> > > Essentially both compress and PCM definitions are identical, and can
> > > be never different because of ABI compatibility, which means it's safe
> > > to mix both variants in the code.  If you're unsure, we may add
> > > BUILD_BUG_ON() to check the coincidence of both values.
> > 
> > 
> > In case we add this BUILD_BUG_ON(), can we keep the code as is then,
> > there's no need to convert values?
> 
> Unless any strong type is used, it should be fine as is.
> BUILD_BUG_ON() would catch if the value is changed inconsistently.

OK, Thanks.
v2 Will use BUILD_BUG_ON().

Thank you for your help !!

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list