[PATCH] ASoC: Intel: sof_rt5682: update quirk for cml boards

Lu, Brent brent.lu at intel.com
Wed Oct 21 16:20:36 CEST 2020


> 
> That setting is not wrong, but is it sufficient?
> 
> see e.g. what we set for existing platforms which need 24 Mhz in this
> driver:
> 
> DMI quirks:
> 
> 	{
> 		.callback = sof_rt5682_quirk_cb,
> 		.matches = {
> 			DMI_MATCH(DMI_PRODUCT_FAMILY,
> "Google_Hatch"),
> 		},
> 		.driver_data = (void *)(SOF_RT5682_MCLK_EN |
> 					SOF_RT5682_MCLK_24MHZ |
> 					SOF_RT5682_SSP_CODEC(0) |
> 					SOF_SPEAKER_AMP_PRESENT |
> 					SOF_RT5682_SSP_AMP(1)),
> 	},
> 

Hi Pierre,

CML chromebox is using DMI quirk so we don't need this patch. Sorry
for not noticing it.

Handle 0x0001, DMI type 1, 27 bytes
System Information
        Manufacturer: Google
        Product Name: Duffy
        Version: rev3
        Serial Number: 123456789
        UUID: Not Settable
        Wake-up Type: Reserved
        SKU Number: sku33554439
        Family: Google_Hatch




More information about the Alsa-devel mailing list